Skip to content

feat: improve CreateWalletDialog look #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 4 commits into from
Dec 4, 2025
Merged

feat: improve CreateWalletDialog look #7039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c201837
feat: make "Advanced Options" toggle in wallet creation dialog look l…
UdjinM6 Dec 4, 2025
39e2f2b
fix: shrink wallet creation dialog when advanced options are hidden
UdjinM6 Dec 4, 2025
aa78fca
fix: adjust focusPolicy
UdjinM6 Dec 4, 2025
c34bd8b
fix: improve QGroupBox styling consistency
UdjinM6 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/qt/createwalletdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ CreateWalletDialog::CreateWalletDialog(QWidget* parent) :
ui(new Ui::CreateWalletDialog)
{
ui->setupUi(this);
layout()->setSizeConstraint(QLayout::SetFixedSize);

ui->buttonBox->button(QDialogButtonBox::Ok)->setText(tr("Create"));
ui->buttonBox->button(QDialogButtonBox::Ok)->setEnabled(false);
ui->wallet_name_line_edit->setFocus(Qt::ActiveWindowFocusReason);
Expand All @@ -28,11 +30,9 @@ CreateWalletDialog::CreateWalletDialog(QWidget* parent) :
ui->groupBox->setVisible(false);
ui->groupBox->setTitle(QString());
ui->advanced_toggle_button->setChecked(false);
ui->advanced_toggle_button->setArrowType(Qt::RightArrow);
ui->advanced_toggle_button->setFocusPolicy(Qt::NoFocus);
connect(ui->advanced_toggle_button, &QToolButton::toggled, this, [this](bool checked) {
ui->groupBox->setVisible(checked);
ui->advanced_toggle_button->setArrowType(checked ? Qt::DownArrow : Qt::RightArrow);
ui->advanced_toggle_button->setText(checked ? tr("Hide Advanced Options") : tr("Show Advanced Options"));
});

connect(ui->wallet_name_line_edit, &QLineEdit::textEdited, [this](const QString& text) {
Expand Down
64 changes: 31 additions & 33 deletions src/qt/forms/createwalletdialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,31 +73,6 @@
</property>
</spacer>
</item>
<item>
<widget class="QToolButton" name="advanced_toggle_button">
<property name="text">
<string>Advanced Options</string>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonTextBesideIcon</enum>
</property>
<property name="autoRaise">
<bool>true</bool>
</property>
<property name="focusPolicy">
<enum>Qt::NoFocus</enum>
</property>
<property name="checkable">
<bool>true</bool>
</property>
<property name="checked">
<bool>false</bool>
</property>
<property name="arrowType">
<enum>Qt::RightArrow</enum>
</property>
</widget>
</item>
<item>
<widget class="QGroupBox" name="groupBox">
<property name="title">
Expand Down Expand Up @@ -182,14 +157,37 @@
</spacer>
</item>
<item>
<widget class="QDialogButtonBox" name="buttonBox">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
<property name="standardButtons">
<set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set>
</property>
</widget>
<layout class="QHBoxLayout" name="horizontalLayout2">
<item>
<widget class="QToolButton" name="advanced_toggle_button">
<property name="text">
<string>Show Advanced Options</string>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonTextOnly</enum>
</property>
<property name="autoRaise">
<bool>true</bool>
</property>
<property name="checkable">
<bool>true</bool>
</property>
<property name="checked">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QDialogButtonBox" name="buttonBox">
<property name="orientation">
<enum>Qt::Horizontal</enum>
</property>
<property name="standardButtons">
<set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set>
</property>
</widget>
</item>
</layout>
</item>
</layout>
</widget>
Expand Down
38 changes: 4 additions & 34 deletions src/qt/res/css/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@ QGroupBox
QGroupBox {
background-color: #39393b;
color: #c7c7c7;
font-size: 16px;
}

/******************************************************
Expand Down Expand Up @@ -397,6 +396,7 @@ QWidget#AddressBookPage QPushButton#newAddress,
QWidget#AddressBookPage QPushButton#copyAddress,
QWidget#AddressBookPage QPushButton#showAddressQRCode,
QWidget#AddressBookPage QPushButton#deleteAddress,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button,
QDialog#OpenURIDialog QPushButton#selectFileButton,
QDialog#OptionsDialog QPushButton#resetButton,
QDialog#SendCoinsDialog .QPushButton#addButton,
Expand All @@ -414,6 +414,7 @@ QWidget#AddressBookPage QPushButton#newAddress:hover,
QWidget#AddressBookPage QPushButton#copyAddress:hover,
QWidget#AddressBookPage QPushButton#showAddressQRCode:hover,
QWidget#AddressBookPage QPushButton#deleteAddress:hover,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:hover,
QDialog#OpenURIDialog QPushButton#selectFileButton:hover,
QDialog#OptionsDialog QPushButton#resetButton:hover,
QDialog#SendCoinsDialog .QPushButton#addButton:hover,
Expand All @@ -431,6 +432,7 @@ QWidget#AddressBookPage QPushButton#newAddress:pressed,
QWidget#AddressBookPage QPushButton#copyAddress:pressed,
QWidget#AddressBookPage QPushButton#showAddressQRCode:pressed,
QWidget#AddressBookPage QPushButton#deleteAddress:pressed,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:pressed,
QDialog#OpenURIDialog QPushButton#selectFileButton:pressed,
QDialog#OptionsDialog QPushButton#resetButton:pressed,
QDialog#SendCoinsDialog .QPushButton#addButton:pressed,
Expand All @@ -448,6 +450,7 @@ QWidget#AddressBookPage QPushButton#newAddress:disabled,
QWidget#AddressBookPage QPushButton#copyAddress:disabled,
QWidget#AddressBookPage QPushButton#showAddressQRCode:disabled,
QWidget#AddressBookPage QPushButton#deleteAddress:disabled,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:disabled,
QDialog#OpenURIDialog QPushButton#selectFileButton:disabled,
QDialog#OptionsDialog QPushButton#resetButton:disabled,
QDialog#SendCoinsDialog .QPushButton#addButton:disabled,
Expand Down Expand Up @@ -1088,39 +1091,6 @@ QScrollBar:right-arrow:disabled {
image: url(':/images/arrow_light_right_hover');
}

/**
* CreateWalletDialog (Dark Theme)
*/

QDialog#CreateWalletDialog QLabel,
QDialog#CreateWalletDialog QCheckBox {
color: #bbbbbb; /* slightly lighter labels */
}

QDialog#CreateWalletDialog QToolButton#advanced_toggle_button {
color: #bdbdbd !important; /* lighter chevron/text */
}

QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:hover {
color: #e0e0e0 !important; /* lighter on hover for better feedback */
}

QDialog#CreateWalletDialog QGroupBox#groupBox {
background-color: #2a2a2a; /* card background */
border: 1px solid #3c3c3c; /* subtle outline */
border-radius: 8px;
padding: 2px 12px 12px 12px; /* minimal top padding */
margin-top: 0px; /* remove extra gap above card */
}

QDialog#CreateWalletDialog QGroupBox#groupBox::title {
padding: 0px; /* ensure no extra space for (empty) title */
}

QDialog#CreateWalletDialog QLineEdit:focus {
border-color: #4da3ff; /* subtle macOS-like blue */
}

/**
* MnemonicVerificationDialog (Dark Theme)
*/
Expand Down
41 changes: 26 additions & 15 deletions src/qt/res/css/general.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ QGroupBox
QGroupBox {
background-color:red;
color: red;
font-size: 16px;
padding-top: 20px;
}

Expand Down Expand Up @@ -1180,6 +1181,31 @@ QDialog#CoinControlDialog .CoinControlTreeWidget#treeWidget::separator {

}

/******************************************************
CreateWalletDialog
******************************************************/

QDialog#CreateWalletDialog QToolButton#advanced_toggle_button {
border: 0px;
border-radius: 8px;
max-height: 26px;
min-height: 26px;
padding-left: 12px;
padding-right: 12px;
padding-top: 4px;
padding-bottom: 4px;
}

QDialog#CreateWalletDialog QGroupBox#groupBox {
border-radius: 8px;
padding: 2px 12px 12px 12px;
margin-top: 0px;
}

QDialog#CreateWalletDialog QGroupBox#groupBox::title {
padding: 0px;
}

/******************************************************
EditAddressDialog
******************************************************/
Expand Down Expand Up @@ -1985,21 +2011,6 @@ QDialog#HelpMessageDialog QScrollBar:horizontal {
}

</os>

/**
* CreateWalletDialog (Layout)
*/

QDialog#CreateWalletDialog QGroupBox#groupBox {
border-radius: 8px;
padding: 2px 12px 12px 12px;
margin-top: 0px;
}

QDialog#CreateWalletDialog QGroupBox#groupBox::title {
padding: 0px;
}

/**
* MnemonicVerificationDialog (Layout)
*/
Expand Down
39 changes: 5 additions & 34 deletions src/qt/res/css/light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ QGroupBox
******************************************************/

QGroupBox {
background-color: #f2f2f4;
background-color: #eaeaec;
color: #555;
}

Expand Down Expand Up @@ -379,6 +379,7 @@ QWidget#AddressBookPage QPushButton#newAddress,
QWidget#AddressBookPage QPushButton#copyAddress,
QWidget#AddressBookPage QPushButton#showAddressQRCode,
QWidget#AddressBookPage QPushButton#deleteAddress,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button,
QDialog#OpenURIDialog QPushButton#selectFileButton,
QDialog#OptionsDialog QPushButton#resetButton,
QDialog#SendCoinsDialog .QPushButton#addButton,
Expand All @@ -396,6 +397,7 @@ QWidget#AddressBookPage QPushButton#newAddress:hover,
QWidget#AddressBookPage QPushButton#copyAddress:hover,
QWidget#AddressBookPage QPushButton#showAddressQRCode:hover,
QWidget#AddressBookPage QPushButton#deleteAddress:hover,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:hover,
QDialog#OpenURIDialog QPushButton#selectFileButton:hover,
QDialog#OptionsDialog QPushButton#resetButton:hover,
QDialog#SendCoinsDialog .QPushButton#addButton:hover,
Expand All @@ -413,6 +415,7 @@ QWidget#AddressBookPage QPushButton#newAddress:pressed,
QWidget#AddressBookPage QPushButton#copyAddress:pressed,
QWidget#AddressBookPage QPushButton#showAddressQRCode:pressed,
QWidget#AddressBookPage QPushButton#deleteAddress:pressed,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:pressed,
QDialog#OpenURIDialog QPushButton#selectFileButton:pressed,
QDialog#OptionsDialog QPushButton#resetButton:pressed,
QDialog#SendCoinsDialog .QPushButton#addButton:pressed,
Expand All @@ -430,6 +433,7 @@ QWidget#AddressBookPage QPushButton#newAddress:disabled,
QWidget#AddressBookPage QPushButton#copyAddress:disabled,
QWidget#AddressBookPage QPushButton#showAddressQRCode:disabled,
QWidget#AddressBookPage QPushButton#deleteAddress:disabled,
QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:disabled,
QDialog#OpenURIDialog QPushButton#selectFileButton:disabled,
QDialog#OptionsDialog QPushButton#resetButton:disabled,
QDialog#SendCoinsDialog .QPushButton#addButton:disabled,
Expand Down Expand Up @@ -1072,39 +1076,6 @@ QScrollBar:right-arrow:disabled {
image: url(':/images/arrow_light_right_normal');
}

/**
* CreateWalletDialog (Light Theme)
*/

QDialog#CreateWalletDialog QLabel,
QDialog#CreateWalletDialog QCheckBox {
color: #555; /* ensure contrast consistent with labels */
}

QDialog#CreateWalletDialog QToolButton#advanced_toggle_button {
color: #555 !important; /* ensure good contrast in light mode */
}

QDialog#CreateWalletDialog QToolButton#advanced_toggle_button:hover {
color: #333 !important; /* darker on hover for better feedback */
}

QDialog#CreateWalletDialog QGroupBox#groupBox {
background-color: #eaeaec; /* card background */
border: 1px solid #dcdcdc; /* subtle outline */
border-radius: 8px;
padding: 2px 12px 12px 12px; /* minimal top padding */
margin-top: 0px; /* remove extra gap above card */
}

QDialog#CreateWalletDialog QGroupBox#groupBox::title {
padding: 0px; /* ensure no extra space for (empty) title */
}

QDialog#CreateWalletDialog QLineEdit:focus {
border-color: #4da3ff; /* macOS-like blue */
}

/**
* MnemonicVerificationDialog (Light Theme)
*/
Expand Down
Loading