Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #772

Merged
merged 2 commits into from
May 10, 2016
Merged

Fix tests #772

merged 2 commits into from
May 10, 2016

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented May 10, 2016

Not sure if anyone noticed but travis is complaining now 😉 This should fix it.

@schinzelh
Copy link

Awesome, thanks!

@schinzelh schinzelh merged commit feabb14 into dashpay:v0.12.1.x May 10, 2016
schinzelh pushed a commit that referenced this pull request May 26, 2016
@UdjinM6 @schinzelh
Re-enable FillBlockPayee for mnpayments, fix CreateNewBlock calculati…
6698d2c 
…ons (#811)

* Reenable FillBlockPayee for mnpayments, fix CreateNewBlock calculations

* revert blockchain.py fix #772
@UdjinM6 UdjinM6 deleted the fixTests branch June 20, 2016 06:45
knst pushed a commit to knst/dash that referenced this pull request Jul 13, 2024
@hebasto
Merge bitcoin-core/gui#773: Check for private keys disabled before at…
c6398c6 
…tempting unlock

517c7f9 gui: Check for private keys disabled before attempting unlock (Andrew Chow)

Pull request description:

  Before trying to unlock a wallet, first check if it has private keys disabled. If so, there is no need to unlock.

  Note that such wallets are not expected to occur in typical usage. However bugs in previous versions allowed such wallets to be created, and so we need to handle them.

  Fixes dashpay#772

  For some additional context, see dashpay#631

ACKs for top commit:
  hebasto:
    ACK 517c7f9, I have reviewed the code and it looks OK.
  BrandonOdiwuor:
    ACK 517c7f9

Tree-SHA512: c92aa34344d04667b70b059d2aa0a1da999cb7239cd1413f3009781aa82379f309ff9808d7dc91d385e2c8afe2abda3564568e2091ef833b1536ebfcf80f7c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UdjinM6 @schinzelh