fix RelayTransaction to relay correct message (dstx/ix) #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve errors like
and hopefully all issues with mixing txes not being propagated/included in block correctly.
Presumably smth like that could also be the reason for poor DS performance on mainnet currently but due to huge number of nodes on mainnet dstx messages just fail to relay on some intermediate nodes so we were not able to catch similar errors. This can rarely/never happen to mixing clients because they are connected to mixing masternode directly but miners cannot have direct connection to every node (there are 3800+ currently, it doesn't make sense to have that many connections) so probably they simply can't see many of dstx messages at all.