V0.12.1.x Sync Processing

[eduffield222]

1. Removed calc-score, I don't believe this serves any use anymore. Score calculation is done on a case-by-case basis depending on the item which needs updating, not as one giant queue
2. Completely all 12.1 todo's that were related to wiring issues.
3. Refactored some governance function names to more apt names
4. Removed bounty signals because the payment system is going to more or less work how 12.0 works, bounties will be defined in 12.2
5. Removed register signals, this will be used for Dashdrive eventually, but I would like to be clearer on the implementation before continuing
6. Removed MNQUORUM and MNSCANERROR. These are going to be moved out of core and into sentinel
7. Reenabled governance item syncing (still not working correctly)
8. Fixed masternode winner calculation and listing (not sure if payments are working yet though)
9. Removed hybrid reference node implementation for masternode payments. It appears 12.0 worked fine without having to utilize "safe-mode", so it appears safe to remove.
10. fCache Signals should now be calculated correctly and are triggered at a minimum of 10% absolute network support (sum of yes-no votes)

[thelazier]

Include .cpp in .h?

[UdjinM6]

pretty sure that's the reason for failed build, should be .h

[schinzelh]

Yep, this fixes the Windows/Linux builds --> https://travis-ci.org/dashpay/dash/builds/132753565

--- a/src/governance.h
+++ b/src/governance.h
@@ -13,7 +13,7 @@
 #include "base58.h"
 #include "masternode.h"
 #include "governance-vote.h"
-#include "masternodeman.cpp"
+#include "masternodeman.h"
 #include <boost/lexical_cast.hpp>
 #include "init.h"

[eduffield222]

yep, thanks

[crowning-]

in src/masternode-sync.cpp:

pnode->ClearFulfilledRequest("spork-sync");
pnode->ClearFulfilledRequest("masternode-winner-sync");
pnode->ClearFulfilledRequest("governance-sync");
pnode->ClearFulfilledRequest("masternode-sync");

I would prefer to have those strings defined somewhere to be able to let the compiler check for typos.

@UdjinM6 : how do you create those line notes?

[schinzelh]

@crowning- just open the diff, there you can add line notes :)

e.g. https://github.com/dashpay/dash/pull/806/files

[schinzelh]

All green, good for merge :)