Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
AddRef()
inConnectNode()
for existing connections doesn't feel right considering how refs are released inThreadSocketHandler()
. I guess this could be the reason that sometimes refs stay >0 no matter what and nodes stuck invNodesDisconnected
forever which means that node never get deleted andFinalizeNode
signal is never fired which in its turn means that for examplemapBlocksInFlight
can't be cleaned properly and then blocks stuck.This commit should solve the issue by:
AddRef()
for existing connectionsAddRef()
inCNode
's constructor using the same conditions as inThreadSocketHandler()
AddRef()
inConnectNode()
andRelease()
inThreadSocketHandler()
for mixing nodesRelease()
(back topnode->fDisconnect = true
inCMasternodeMan::ProcessMasternodeConnections
)