Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regtest no quorums bug #163

Merged
merged 4 commits into from
Jun 26, 2020
Merged

fix: regtest no quorums bug #163

merged 4 commits into from
Jun 26, 2020

Conversation

Cofresi
Copy link

@Cofresi Cofresi commented Jun 26, 2020

Issue being fixed or feature implemented

When running mn-bootstrap in regtest there are no quorums and this case needs to be handled

What was done?

check if there are no quorums and skip relevant logic

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@Cofresi Cofresi requested a review from shuplenkov June 26, 2020 15:10
shuplenkov
shuplenkov previously approved these changes Jun 26, 2020
Copy link
Collaborator

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Cofresi Cofresi merged commit c1570bd into master Jun 26, 2020
@Cofresi Cofresi deleted the fix-no-quorums-bug branch June 29, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants