Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sml): version is mandatory for SML entry #289

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 22, 2023

Issue being fixed or feature implemented

With Core 19.2, each SML Entry maintain own version

What was done?

  • Do not overwrite entry version with diff version
  • Clone nested objects as well
  • Serialize type only for version 2

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@shumkov shumkov changed the title feat(sml): version is mandatory for sml entry feat(sml): version is mandatory for SML entry Jun 22, 2023
@shumkov shumkov merged commit 66186b1 into master Jun 22, 2023
@shumkov shumkov deleted the feat/sml/add_version branch June 22, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants