Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mn entry version deserialisation #297

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: mn entry version deserialisation #297

merged 1 commit into from
Jul 5, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 5, 2024

Issue being fixed or feature implemented

Merkle root verification failed in SML if we have entries with type 0 and version 2

What was done?

  • Set version 2 on MN Entry deserialization if type 0 as well.

How Has This Been Tested?

Running test suite against devnet

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@shumkov shumkov changed the title fix: mn entry version deserialization fix: mn entry version deserialisation Jul 5, 2024
ogabrielides
ogabrielides approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov merged commit 8c0eec5 into master Jul 5, 2024
2 checks passed
@shumkov shumkov deleted the fix/mn-entry-deserialization branch July 5, 2024 12:43
@Mhmonicox Mhmonicox mentioned this pull request Jul 30, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 28, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 14, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 24, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielides ogabrielides ogabrielides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @ogabrielides