fix(coinjoin): account for 0 diff transactions when emitting events

[Syn-McJ]

Issue being fixed or feature implemented

CoinJoin transactions have a zero amount, preventing sent/received events from being emitted.

What was done?

• Replace diff check with diff >= 0 to emit the coinsReceived event.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes
  • Improved transaction event notification logic to provide more comprehensive updates about wallet transactions.
  • Enhanced balance tracking to notify listeners for zero-sum and balance-changing transactions.

[coderabbitai]

Walkthrough

The changes in the Wallet.java file modify the transaction processing logic, specifically adjusting how the wallet notifies listeners about coin transactions. The modifications expand the conditions for triggering notifications, allowing listeners to be informed about transactions even when the balance remains unchanged or experiences minimal changes. This update provides more comprehensive transaction event reporting within the wallet's event notification mechanism.

Changes

File	Change Summary
core/src/main/java/org/bitcoinj/wallet/Wallet.java	- Modified receive() method to notify listeners when balance is greater than or equal to zero - Simplified coin sent notification logic to trigger on any balance change

Poem

🐰 A Rabbit's Wallet Tale 🪙

Transactions flow, both big and small,
Notifications now answer every call
Zero or change, the balance may sway
Listeners hear what transactions say
BitcoinJ's wallet, now more aware! 🚀

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

core/src/main/java/org/bitcoinj/wallet/Wallet.java (1)

2423-2427: Consider documenting the event emission behavior

The event emission logic handles an important edge case for CoinJoin transactions. Consider adding a comment explaining why zero-diff transactions need to emit coinsReceived events, as this behavior may not be immediately obvious to future maintainers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a8ffcf and a8df760.

📒 Files selected for processing (1)

• core/src/main/java/org/bitcoinj/wallet/Wallet.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: JAVA 11 OS macOS-latest Gradle
• GitHub Check: Analyze (java)
• GitHub Check: JAVA 11 OS ubuntu-latest Gradle

🔇 Additional comments (2)

core/src/main/java/org/bitcoinj/wallet/Wallet.java (2)

2423-2425: LGTM! Improved handling of zero-diff transactions

The change to include diff >= 0 instead of just diff > 0 correctly implements support for CoinJoin transactions that may have zero balance difference.

---

2425-2427: LGTM! Maintains correct behavior for sent coins

The else block correctly handles the case when coins are sent (diff < 0) by queueing the appropriate coinsSent event.