chore: update dashj-bls to 1.0.1-SNAPSHOT #272
Conversation
WalkthroughThe changes update the subproject reference in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
contrib/dashj-bls(1 hunks)core/build.gradle(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- contrib/dashj-bls
🧰 Additional context used
🪛 GitHub Actions: CodeQL
core/build.gradle
[error] 1-1: Could not find org.dashj:dashj-bls:1.0.1-SNAPSHOT. Required by project :dashj-wallettemplate.
[error] 1-1: Could not resolve all files for configuration ':dashj-wallettemplate:runtimeClasspath'.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: JAVA 11 OS macOS-latest Gradle
- GitHub Check: JAVA 11 OS ubuntu-latest Gradle
🔇 Additional comments (1)
core/build.gradle (1)
126-137:❓ Verification inconclusive
Verify Maven repository configuration.
The build is configured to use Sonatype repositories for both releases and snapshots. Ensure that:
- The SNAPSHOT version is being published to the correct repository
- The build has proper credentials configured for dependency resolution
Let's verify the repository configuration:
🏁 Script executed:
#!/bin/bash # Verify repository access and credentials # Test repository access echo "Testing Sonatype snapshots repository access..." curl -I "https://s01.oss.sonatype.org/content/repositories/snapshots/" # Check if credentials are configured in environment echo -e "\nChecking credential configuration..." if [ -f ~/.gradle/gradle.properties ]; then echo "Gradle properties file exists" grep -c "ossrh" ~/.gradle/gradle.properties || echo "No ossrh credentials found" else echo "No Gradle properties file found" fiLength of output: 1188
Action Required: Verify credentials provisioning for Sonatype repository
The repository URLs are confirmed accessible (HTTP/200 returned for the snapshots URL), and the code correctly routes SNAPSHOT versions to the snapshots repository. However, the automated check did not find a
~/.gradle/gradle.propertiesfile containing the OSSRH credentials. This may be acceptable if the credentials are provided via an alternative mechanism (e.g., CI environment variables or project-level properties).Please verify:
- That the necessary
ossrhUsernameandossrhPasswordare injected into the build through another mechanism if not via~/.gradle/gradle.properties.- That SNAPSHOT and release artifacts are published to the correct repositories.
| @@ -28,7 +28,7 @@ dependencies { | |||
|
|
|||
| // Dash Specific | |||
| implementation 'de.sfuhrm:saphir-hash-core:3.0.10' | |||
| implementation 'org.dashj:dashj-bls:1.0.0' | |||
| implementation 'org.dashj:dashj-bls:1.0.1-SNAPSHOT' | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Critical: Build failure due to missing SNAPSHOT dependency.
The pipeline is failing because it cannot resolve org.dashj:dashj-bls:1.0.1-SNAPSHOT. This is blocking the build process.
Let's verify the availability of the package in the Maven repositories:
Consider these solutions:
- If the SNAPSHOT version is intentional (e.g., for development):
- Ensure the SNAPSHOT is published to the Sonatype snapshots repository
- Verify the subproject build publishes the artifact before the main build
- If this should be a release version:
- Update to a released version instead of a SNAPSHOT
- implementation 'org.dashj:dashj-bls:1.0.1-SNAPSHOT' + implementation 'org.dashj:dashj-bls:1.0.1'
🏁 Script executed:
#!/bin/bash
# Check if the SNAPSHOT version exists in the configured Maven repositories
# Check Sonatype snapshots repository
echo "Checking Sonatype snapshots repository..."
curl -s "https://s01.oss.sonatype.org/content/repositories/snapshots/org/dashj/dashj-bls/1.0.1-SNAPSHOT/maven-metadata.xml" || echo "Not found in Sonatype snapshots"
# Check Maven Central (though SNAPSHOTs shouldn't be here)
echo -e "\nChecking Maven Central..."
curl -s "https://repo1.maven.org/maven2/org/dashj/dashj-bls/maven-metadata.xml" || echo "Not found in Maven Central"Length of output: 1752
Critical: Unresolved Dependency Must Be Addressed
The build is currently failing because the dependency
implementation 'org.dashj:dashj-bls:1.0.1-SNAPSHOT'cannot be resolved. Our verification shows that the 1.0.1-SNAPSHOT artifact is missing from the Sonatype snapshots repository, and Maven Central only offers versions up to 1.0.0.
Next steps:
- If a SNAPSHOT is intended: Ensure that the 1.0.1-SNAPSHOT artifact is published to the snapshots repository (and that any subproject responsible for publishing it is successfully running before this build).
- Otherwise: Switch to a released version. For example:
- implementation 'org.dashj:dashj-bls:1.0.1-SNAPSHOT' + implementation 'org.dashj:dashj-bls:1.0.0'
Please address this to ensure the build can resolve all dependencies.
Issue being fixed or feature implemented
Update to DashJ-BLS 1.0.1
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit