Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain SSL certificate chain format #380

Merged
merged 3 commits into from
Aug 30, 2024
Merged

docs: explain SSL certificate chain format #380

merged 3 commits into from
Aug 30, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 28, 2024

Comment on lines 632 to 633
intermediate/root certificates if present. Usually, you need to concatenate the certificate file and
bundle if present.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: "usually you need to concatenate ..."
Do you think we should show an example of how to do this? I'm not very familiar with this cert stuff, so I don't know if most people will understand or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what example you want to give? How do we concatenate two files in case if user receives it separately?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it is clear as-is, we can go with it and update later if we get questions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not clear for you then we probably need to give more information. What exactly is not clear for you?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, do they just need to do smth like cat file1 file2 > combined_file to actually concatenate the files. Or is there a specific ssl / cert related command?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just like that: cat certificate.crt bundle.crt > full_chain.crt

Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
thephez previously approved these changes Aug 28, 2024
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shumkov
Copy link
Member Author

shumkov commented Aug 30, 2024

Yes, totally. Thank you

@shumkov shumkov merged commit 309ecf0 into 21.0.0 Aug 30, 2024
@shumkov shumkov deleted the shumkov-patch-1 branch August 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants