Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved credit transfer strategies #97

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

@pauldelucia pauldelucia marked this pull request as ready for review November 4, 2024 16:18
@pauldelucia pauldelucia marked this pull request as draft November 4, 2024 16:18
@pauldelucia pauldelucia marked this pull request as ready for review November 5, 2024 10:57
SetStartIdentitiesBalance(String, u64),
AddOperation {
strategy_name: String,
operation: Operation,
},
RegisterDocsToAllContracts(String, u16, DocumentFieldFillSize, DocumentFieldFillType),
RunStrategy(String, u64, bool, bool, u64),
RunStrategy(String, u64, u64, bool, u64),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day it should be a variant with named parameters

.fetch_add(1, Ordering::SeqCst);
}
};
match e.inner {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match with one arm usually covered by if let

@@ -90,6 +93,13 @@ impl OperationsScreenController {
let supporting_contracts_lock = app_state.supporting_contracts.lock().await;
let strategy_contract_names_lock =
app_state.available_strategies_contract_names.lock().await;
let loaded_identity = app_state.loaded_identity.lock().await;

let loaded_identity_id = if let Some(identity) = &*loaded_identity {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like .map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants