Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update rust to 1.83 - backport #2393 to v1.7 #2398

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Dec 18, 2024

Issue being fixed or feature implemented

Tests fail

What was done?

Backport #2393

How Has This Been Tested?

GHA

Breaking Changes

New version of Rust is needed to build

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • New Features

    • Updated minimum required Rust version to 1.83 across the project.
  • Documentation

    • Revised Rust version requirement in setup instructions of the README file to 1.83+.
  • Chores

    • Adjusted the Rust toolchain version in the configuration file to 1.83.

@lklimek lklimek added this to the v1.7.x milestone Dec 18, 2024
Copy link
Contributor

coderabbitai bot commented Dec 18, 2024

Walkthrough

This pull request focuses on updating the Rust version across multiple configuration files from version 1.80 to 1.83. The changes are consistent and systematic, affecting the Cargo.toml, README.md, and rust-toolchain.toml files. The modifications ensure that the project's toolchain and documentation reflect the new minimum Rust version requirement, with minor formatting adjustments in the Cargo.toml file.

Changes

File Change Summary
Cargo.toml - Updated rust-version from "1.80" to "1.83"
- Added trailing comma after "packages/wallet-utils-contract" in workspace members
README.md - Updated Rust version requirement from v1.80+ to v1.83+ in prerequisites section
rust-toolchain.toml - Updated toolchain channel version from "1.80" to "1.83"

Possibly related PRs

Suggested labels

cleanup

Suggested reviewers

  • QuantumExplorer
  • shumkov

Poem

🐰 Rust version hopping, one dot higher,
From 1.80 to 1.83, climbing ever higher!
Config files dancing, toolchain so bright,
A rabbit's update brings pure delight! 🚀
Version bump complete, code sailing free!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d318b1c and f2f729f.

📒 Files selected for processing (3)
  • Cargo.toml (1 hunks)
  • README.md (1 hunks)
  • rust-toolchain.toml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • rust-toolchain.toml
  • README.md
🔇 Additional comments (2)
Cargo.toml (2)

31-31: LGTM! Good practice with trailing comma

The addition of a trailing comma in the workspace members list is a good practice that makes future additions cleaner and reduces git diff noise.


35-35: Verify Rust version consistency across configuration files

The update to Rust 1.83 is a breaking change. Let's verify the version is consistently updated across all relevant files and that it's a stable release.

✅ Verification successful

Let me generate additional verification scripts to check the specific version references in these files and ensure they are consistent.


Rust version 1.83 is consistently configured across the project

The verification shows that Rust version 1.83 is properly configured and consistent across the codebase:

  • The main Cargo.toml sets rust-version = "1.83"
  • rust-toolchain.toml specifies channel = "1.83"
  • All package-level Cargo.toml files use workspace inheritance (rust-version.workspace = true)
  • README.md correctly states the requirement as "rust v1.83+"

Note: The version "0.1.83" found in Cargo.lock is unrelated as it refers to a dependency version, not the Rust version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Rust version consistency across configuration files and check release status

# Check for Rust version references in other files
echo "Checking Rust version references in configuration files..."
rg -l "1\.8[0-9]" 

# Check rust-toolchain.toml specifically
echo "Checking rust-toolchain.toml content..."
if [ -f "rust-toolchain.toml" ]; then
    cat rust-toolchain.toml
fi

# Check README.md for version requirements
echo "Checking README.md for Rust version requirements..."
if [ -f "README.md" ]; then
    rg "rust|Rust" README.md
fi

Length of output: 999


Script:

#!/bin/bash
# Check exact version references in identified files
echo "=== Checking version in Cargo.toml ==="
rg "rust-version|channel\s*=" Cargo.toml -A 1

echo -e "\n=== Checking version in Cargo.lock ==="
rg "1\.83" Cargo.lock

echo -e "\n=== Checking version in CHANGELOG.md ==="
rg "1\.83" CHANGELOG.md

echo -e "\n=== Checking version in packages/rs-sdk/Cargo.toml ==="
rg "rust-version|channel\s*=" packages/rs-sdk/Cargo.toml -A 1

# Check if there are any other version requirements that might conflict
echo -e "\n=== Checking for any other Rust version requirements ==="
rg "rust[-\s]version|RUST[-\s]VERSION|channel\s*=" --type toml --type md

Length of output: 2580


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lklimek lklimek changed the base branch from v1.8-dev to master December 18, 2024 09:26
@lklimek lklimek changed the title build!: update rust to 1.83 - backport #2393 build!: update rust to 1.83 - backport #2393 to v1.7 Dec 18, 2024
@QuantumExplorer QuantumExplorer merged commit 21ec393 into master Dec 18, 2024
22 checks passed
@QuantumExplorer QuantumExplorer deleted the backport/rust-1.83 branch December 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants