-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: update rust to 1.83 - backport #2393 to v1.7 #2398
Conversation
WalkthroughThis pull request focuses on updating the Rust version across multiple configuration files from version 1.80 to 1.83. The changes are consistent and systematic, affecting the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🔇 Additional comments (2)Cargo.toml (2)
The addition of a trailing comma in the workspace members list is a good practice that makes future additions cleaner and reduces git diff noise.
The update to Rust 1.83 is a breaking change. Let's verify the version is consistently updated across all relevant files and that it's a stable release. ✅ Verification successfulLet me generate additional verification scripts to check the specific version references in these files and ensure they are consistent. Rust version 1.83 is consistently configured across the project The verification shows that Rust version 1.83 is properly configured and consistent across the codebase:
Note: The version "0.1.83" found in Cargo.lock is unrelated as it refers to a dependency version, not the Rust version. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify Rust version consistency across configuration files and check release status
# Check for Rust version references in other files
echo "Checking Rust version references in configuration files..."
rg -l "1\.8[0-9]"
# Check rust-toolchain.toml specifically
echo "Checking rust-toolchain.toml content..."
if [ -f "rust-toolchain.toml" ]; then
cat rust-toolchain.toml
fi
# Check README.md for version requirements
echo "Checking README.md for Rust version requirements..."
if [ -f "README.md" ]; then
rg "rust|Rust" README.md
fi
Length of output: 999 Script: #!/bin/bash
# Check exact version references in identified files
echo "=== Checking version in Cargo.toml ==="
rg "rust-version|channel\s*=" Cargo.toml -A 1
echo -e "\n=== Checking version in Cargo.lock ==="
rg "1\.83" Cargo.lock
echo -e "\n=== Checking version in CHANGELOG.md ==="
rg "1\.83" CHANGELOG.md
echo -e "\n=== Checking version in packages/rs-sdk/Cargo.toml ==="
rg "rust-version|channel\s*=" packages/rs-sdk/Cargo.toml -A 1
# Check if there are any other version requirements that might conflict
echo -e "\n=== Checking for any other Rust version requirements ==="
rg "rust[-\s]version|RUST[-\s]VERSION|channel\s*=" --type toml --type md
Length of output: 2580 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Issue being fixed or feature implemented
Tests fail
What was done?
Backport #2393
How Has This Been Tested?
GHA
Breaking Changes
New version of Rust is needed to build
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
Documentation
Chores