Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use all current identities for strategy test state transitions #1820

Merged
merged 4 commits into from
May 7, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Apr 17, 2024

Issue being fixed or feature implemented

We were just using the first identity in current_identities for some operations

What was done?

Select a random identity from current identities instead.

How Has This Been Tested?

Platform TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia changed the title feat: use all current identities for ContractCreate operation feat: use all current identities for strategy test state transitions Apr 17, 2024
@pauldelucia pauldelucia marked this pull request as ready for review May 7, 2024 12:59
@QuantumExplorer QuantumExplorer merged commit c7a1b0f into v1.0-dev May 7, 2024
29 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/use-all-identities-in-strategies branch May 7, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants