Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make start identities number u16 #1841

Merged
merged 2 commits into from
May 9, 2024
Merged

feat: make start identities number u16 #1841

merged 2 commits into from
May 9, 2024

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

Strategy start identities number was u8. We need more than 255.

What was done?

Change to u16.

How Has This Been Tested?

Platform TUI and cargo tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia merged commit b34de38 into v1.0-dev May 9, 2024
17 checks passed
@pauldelucia pauldelucia deleted the feat/make-start-identities-u16 branch May 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldelucia @shumkov