-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(drive-abci): debug docker image with grovedb visualizer and tokio console #2012
Conversation
do not merge for now |
3250692
to
3bfde85
Compare
This reverts commit f9fa858.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where we add f
If you mean "where we add features", it's in Dockerfile lines 202-209, https://github.com/dashpay/platform/pull/2012/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R202-R209 |
Issue being fixed or feature implemented
When building drive-abci image, we don't want to include tools like grovedb visualizer or tokio console.
However, for some use cases, we need these features.
We need to build additional debug package that will accompany normal release and contain forementioned features.
What was done?
-debug
, for example for1.2.3-dev.1
, we builddashpay/drive-abci:1.2.3-dev.1
anddashpay/drive-abci:1.2.3-dev.1-debug
.tokio_unstable
,tokio console
andgrovedbg
are enabled. For release builds (release cargo profile), this is changed on Dockerfile level - drive-abci builds with--no-default-features
, and we use separate config file that hastokio_unstable
disabled.release
cargo profile (as previously),-debug
one indev
cargo profile.How Has This Been Tested?
Manual workflow run
https://github.com/dashpay/platform/actions/runs/10508658962
Prerelease v1.1.0-pr.2012.6
https://github.com/dashpay/platform/actions/runs/10508221419
Test of generated drive-abci image
Debug
Release
Not tested
Breaking Changes
We no longer tag images with tags like 1-dev, latest-dev, etc.
Checklist:
For repository code-owners and collaborators only