Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): core reindex command not working #2054

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

pshenmic
Copy link
Collaborator

Issue being fixed or feature implemented

Reindex command is not working properly in the dashmate, it breaks the whole dash config by trimming \n characters. As a result, node begins to sync mainnet with all default options.

This PR fixes dashmate core reindex command

What was done?

Moved dots.templateSettings.strip = false from renderServiceTemplatesFactory to renderTemplateFactory

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic added this to the v1.1.0 milestone Aug 14, 2024
@pshenmic pshenmic self-assigned this Aug 14, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit c554062 into v1.1-dev Aug 14, 2024
21 checks passed
@shumkov shumkov deleted the fix/dashmate-reindex branch August 14, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants