Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): use proofs when waiting for asset lock #2067

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Aug 22, 2024

Issue being fixed or feature implemented

During code review, I identified place where proofs were not requested for epoch inside wait_for_asset_lock_proof_for_transaction

What was done?

Use sdk methods that verify proof instead of rs-dapi-client features.

How Has This Been Tested?

Not tested

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.2.0 milestone Aug 23, 2024
Copy link
Member

@pauldelucia pauldelucia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully created an identity and topped it up using this PR in the TUI

@shumkov shumkov changed the base branch from v1.1-dev to master August 25, 2024 07:39
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 07:39
@lklimek lklimek modified the milestones: v1.2.0, v1.3.0 Sep 4, 2024
@lklimek lklimek changed the base branch from master to v1.3-dev September 4, 2024 13:52
@lklimek lklimek merged commit 7f350a6 into v1.3-dev Sep 4, 2024
23 of 24 checks passed
@lklimek lklimek deleted the fix/sdk-always-proof branch September 4, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants