Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): doctor diagnostic #2085

Merged
merged 43 commits into from
Sep 17, 2024
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 27, 2024

Issue being fixed or feature implemented

We want the dashmate doctor command not just to report but to analyse reports and identify basic issues. Sine the list of possible checks is endless, we want to implement only basic ones for the first iteration.

What was done?

  • Spilt doctor command into two commands:
    • dashmate doctor to collect and analyse samples.
    • dashmate doctor report to create an archive with
  • Added an option to analyse already created archive
  • Analyse collected data:
    • Docker installation
    • Configuration
      • Gateway admin is disabled while metrics are enabled
      • Platform Node ID
      • SSL certificate (file, self-signed, zerossl)
      • Core P2P port
      • Gateway HTTP port
      • Tenderdash P2P port
    • Core
      • Core is syncing
      • PoSe
    • Platform
      • Tenderdash is syncing
    • Service containers
      • Container is not started
      • Container exited with error code
      • Container is OOMKilled
    • System resources
      • CPU cores
      • CPU speed
      • CPU load
      • RAM total
      • RAM free
      • Swap
      • Disk space
      • Disk IO wait time
      • Open file descriptors
  • Memorise docker installation check

How Has This Been Tested?

  • Run commands locally
  • Simulate different conditions
  • Added unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v1.2-dev to master September 4, 2024 13:17
@shumkov shumkov self-assigned this Sep 5, 2024
@shumkov shumkov added the dashmate Dashmate related label Sep 5, 2024
@shumkov shumkov added this to the v1.3.0 milestone Sep 5, 2024
@shumkov shumkov changed the title feat(dashmate): doctor analysis feat(dashmate): doctor diagnostic Sep 15, 2024
@shumkov shumkov changed the base branch from master to v1.3-dev September 15, 2024 11:38
@shumkov shumkov marked this pull request as ready for review September 15, 2024 13:09
pshenmic
pshenmic previously approved these changes Sep 15, 2024
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Co-authored-by: thephez <thephez@users.noreply.github.com>
shumkov and others added 20 commits September 16, 2024 22:12
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
thephez previously approved these changes Sep 17, 2024
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc ACK 👍

Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reviewed, Approved based on other reviewers.

@shumkov shumkov merged commit f2ded52 into v1.3-dev Sep 17, 2024
21 checks passed
@shumkov shumkov deleted the feat/dashmate/doctor-analisis branch September 17, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashmate Dashmate related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants