Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dapi): implement getIdentityBalance #2105

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Sep 4, 2024

Issue being fixed or feature implemented

GetIdentityBalance is missing from the js dapi client. @owl352 added an implementation for this query in the #2098. I pulled these changes and added a tests.

What was done?

How Has This Been Tested?

In the local mode by @owl352

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic self-assigned this Sep 4, 2024
@pshenmic pshenmic marked this pull request as draft September 4, 2024 15:36
@pshenmic pshenmic marked this pull request as ready for review September 12, 2024 18:56
@pshenmic pshenmic changed the title fix(js-dapi-client): fix queries fix(js-dapi-client): implement getIdentityBalance Sep 12, 2024
@thephez thephez added this to the v1.3.0 milestone Sep 12, 2024
@pshenmic pshenmic changed the title fix(js-dapi-client): implement getIdentityBalance feat(dapi): implement getIdentityBalance Sep 13, 2024
shumkov
shumkov previously approved these changes Sep 16, 2024
@QuantumExplorer QuantumExplorer added the js-sdk JS Dash SDK related label Sep 17, 2024
@QuantumExplorer QuantumExplorer merged commit 2954e29 into v1.3-dev Sep 17, 2024
51 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/dapi-queries branch September 17, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js-sdk JS Dash SDK related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants