Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashmate)!: docker logs rotation #2125

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Sep 16, 2024

Issue being fixed or feature implemented

Dashmate docker logs grows infinitely and could lead to a node downtime due to lack of disk space.

What was done?

  • Configured log compression and rotation for dashmate docker services
  • Switch to more efficient in our case the "local" logging driver.

How Has This Been Tested?

None

Breaking Changes

Previously, dashmate docker services write json file logs on disk using the json-file driver. Not it uses more efficient internal binary format for logs. This will affect you only if you work directly with log files. The docker logs works as before.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.3.0 milestone Sep 16, 2024
@shumkov shumkov self-assigned this Sep 16, 2024
@QuantumExplorer QuantumExplorer merged commit aca6712 into v1.3-dev Sep 17, 2024
21 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/dashmate/docker-log-rotate branch September 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants