chore(dashmate)!: docker logs rotation #2125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate docker logs grows infinitely and could lead to a node downtime due to lack of disk space.
What was done?
How Has This Been Tested?
None
Breaking Changes
Previously, dashmate docker services write json file logs on disk using the
json-file
driver. Not it uses more efficient internal binary format for logs. This will affect you only if you work directly with log files. Thedocker logs
works as before.Checklist:
For repository code-owners and collaborators only