Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about js-sdk security #2133

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Sep 16, 2024

Issue being fixed or feature implemented

Since this SDK doesn't support proofs we need a warning to make sure that is obvious

Replaces #2106 which couldn't complete CI

What was done?

Add warning to top of README

How Has This Been Tested?

N/A

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@thephez thephez changed the title Js sdk warning docs: add warning about js-sdk security Sep 16, 2024
@QuantumExplorer QuantumExplorer merged commit ecd5b4d into v1.3-dev Sep 17, 2024
38 of 43 checks passed
@QuantumExplorer QuantumExplorer deleted the js-sdk-warning branch September 17, 2024 13:34
@thephez thephez added this to the v1.3.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants