Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not run test on push #2308

Merged
merged 1 commit into from
Nov 6, 2024
Merged

ci: do not run test on push #2308

merged 1 commit into from
Nov 6, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 3, 2024

Issue being fixed or feature implemented

We are running tests not just for each PR but for push as well. When you merge PR to master, it's a push to master so we run tests twice

What was done?

  • Do not trigger test on push

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated workflow triggers to run only on specific pull request events and manual dispatch, removing previous push and schedule triggers.

Copy link
Contributor

coderabbitai bot commented Nov 3, 2024

Walkthrough

The changes in the .github/workflows/tests.yml file involve the removal of the push and schedule triggers from the workflow configuration. The workflow will now execute jobs solely based on the workflow_dispatch event and specific pull request events such as opened, synchronized, reopened, and ready_for_review. The jobs affected include various testing and building tasks, which will now operate under the new trigger conditions. The concurrency settings remain unchanged, and there are no modifications to the job definitions.

Changes

File Change Summary
.github/workflows/tests.yml Removed push and schedule triggers; updated job execution conditions to rely on workflow_dispatch and specific pull request events.

Possibly related PRs

  • test(test-suite): enable withdrawal tests #2202: The changes in the main PR regarding the workflow triggers may relate to the testing processes outlined in this PR, which involves enabling tests in the test suite, potentially affecting how tests are executed in the workflow.
  • fix(dashmate): invalid drive status check #2248: Although primarily focused on status checks, this PR's updates to the testing framework and command execution may intersect with the changes in the main PR that affect how tests are triggered and executed in the workflow.

Poem

🐰 In the garden where bunnies play,
The workflow changes come to stay.
No more pushes, just a gentle call,
For tests to run, one and all.
With every pull request in sight,
Our coding dreams take flight! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between feacde2 and 1f77b34.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/tests.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shumkov shumkov mentioned this pull request Nov 3, 2024
20 tasks
@shumkov shumkov merged commit 48cca1a into v1.6-dev Nov 6, 2024
121 checks passed
@shumkov shumkov deleted the ci/do-not-run-test-on-push branch November 6, 2024 14:57
@shumkov shumkov restored the ci/do-not-run-test-on-push branch November 8, 2024 14:30
shumkov added a commit that referenced this pull request Nov 8, 2024
QuantumExplorer pushed a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants