Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update blsful to 3.0.0-pre8 #49

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jan 13, 2025

Summary by CodeRabbit

  • Chores
    • Updated package version from 0.34.0 to 0.35.0
    • Updated blsful dependency from version 3.0.0-pre6 to 3.0.0-pre8
  • Tests
    • Modified test case assertion for the identity_invitation_path method to reflect updated expected output format.

Copy link

coderabbitai bot commented Jan 13, 2025

Walkthrough

The pull request involves updating the version of the dashcore package and the blsful dependency in the Cargo.toml file. The package version is incremented from 0.34.0 to 0.35.0, and the blsful dependency is updated from version 3.0.0-pre6 to 3.0.0-pre8. Additionally, a test case in the dash/src/bip32.rs file has been modified to reflect a change in the expected output format for the identity_invitation_path method.

Changes

File Change Summary
dash/Cargo.toml - Package version updated from 0.34.0 to 0.35.0
- blsful dependency version updated from 3.0.0-pre6 to 3.0.0-pre8
dash/src/bip32.rs - Updated assertion in the test case for identity_invitation_path method to include a single quote at the end of the expected output.

Poem

🐰 Hop, hop, version update time!
Cargo.toml gets a little climb
From 0.34 to 0.35 we go
Blsful dancing to a new tempo
Rust dependencies in perfect rhyme! 🦀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5f5c29 and a42ad6f.

📒 Files selected for processing (1)
  • dash/src/bip32.rs (1 hunks)
🔇 Additional comments (1)
dash/src/bip32.rs (1)

1849-1849: LGTM! Test case now correctly reflects the implementation.

The updated test case assertion now properly matches the implementation of identity_invitation_path which uses ChildNumber::Hardened for the index parameter. This ensures the test accurately verifies that the last component of the path is hardened.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shumkov shumkov self-assigned this Jan 13, 2025
@lklimek
Copy link

lklimek commented Jan 14, 2025

checks red, please fix the tests

@shumkov
Copy link
Member Author

shumkov commented Jan 14, 2025

@lklimek CI is broken long ago. It's not a scope of this PR. Tests are passing locally

@QuantumExplorer QuantumExplorer merged commit 521a76b into master Jan 14, 2025
2 of 25 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/update/update-bls branch January 14, 2025 22:37
shumkov pushed a commit that referenced this pull request Feb 28, 2025
* chore: updated version to 0.15.5

* chore: updated version to 0.15.6

* chore: updated version to 0.15.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants