Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mockpv): detect and fix data-race in MockPV #262

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

shotonoff
Copy link
Collaborator

Issue being fixed or feature implemented

There was detected data race in MockPV

What was done?

Added data sync in several exportable methods MockPV

How Has This Been Tested?

Using unit-tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Collaborator

@lklimek lklimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shotonoff shotonoff merged commit 3b6f545 into v0.8-dev Feb 14, 2022
@shotonoff shotonoff deleted the fix-data-race-in-mock-of-priv-val branch February 14, 2022 15:03
shotonoff pushed a commit that referenced this pull request May 10, 2022
* modify readme

* add rfc and proto

* add rust=spec back to avoid breakage

* lint readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants