Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve statesync.backfill #316

Merged
merged 3 commits into from
Mar 31, 2022
Merged

refactor: improve statesync.backfill #316

merged 3 commits into from
Mar 31, 2022

Conversation

shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Mar 30, 2022 •
edited
Loading

Issue being fixed or feature implemented

Noticed that the unit-test TestReactor_Backfill

  1. works unstable
  2. takes time

In this PR, I tried to eliminate both mentioned issues

What was done?

  1. Made sleep and request timeouts configurable, to be able to use different values for the test
  2. refactor context usage

How Has This Been Tested?

unit-test

Breaking Changes

no

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek
lklimek approved these changes Mar 31, 2022
View reviewed changes
internal/statesync/reactor.go Outdated Show resolved Hide resolved
@shotonoff shotonoff merged commit eb6b173 into v0.8-dev Mar 31, 2022
@shotonoff shotonoff deleted the improve-statesync-backfill branch March 31, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lklimek lklimek lklimek approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shotonoff @lklimek