Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI e2e action workflow #319

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Mar 31, 2022

Issue being fixed or feature implemented

Noticed that sometimes an e2e pipeline job is failure due to a docker-compose file being already removed
it happens because of e2e test uses run-multiple.sh to run / print logs and cleanup generated files,
so, to fix this, we have to deprecate using a script and manage every action in a separate job step

What was done?

  • Combine two jobs (dashcore, rotate) in one
  • Direct call
  • Cleanup CI e2e network in separate step

How Has This Been Tested?

Breaking Changes

no

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shotonoff shotonoff changed the title chore: update e2e.yml chore: update CI e2e action workflow Mar 31, 2022
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@shotonoff shotonoff requested a review from lklimek April 1, 2022 09:46
Copy link
Collaborator Author

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered

.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@shotonoff shotonoff merged commit 5111d48 into v0.8-dev Apr 1, 2022
@shotonoff shotonoff deleted the fix-deleting-docker-compose-file branch April 1, 2022 12:40
shotonoff pushed a commit that referenced this pull request May 10, 2022
Bumps [actions/stale](https://github.com/actions/stale) from 3.0.19 to 4.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v3.0.19...v4)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants