Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update abci++ spec #414

Merged
merged 6 commits into from
Sep 1, 2022
Merged

chore: update abci++ spec #414

merged 6 commits into from
Sep 1, 2022

Conversation

shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Jul 11, 2022 •
edited
Loading

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jul 23, 2022
thephez
thephez reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions

spec/abci++/abci++_methods_002_draft.md Outdated Show resolved Hide resolved
spec/abci++/abci++_methods_002_draft.md Outdated Show resolved Hide resolved
spec/abci++/abci++_methods_002_draft.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Aug 7, 2022
@github-actions github-actions bot removed the Stale label Aug 10, 2022
@shotonoff shotonoff changed the base branch from v0.8-dev to v0.9-dev August 15, 2022 14:17
shotonoff and others added 3 commits August 15, 2022 16:18
@shotonoff @thephez
Update spec/abci++/abci++_methods_002_draft.md
9946bf6 
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff @thephez
Update spec/abci++/abci++_methods_002_draft.md
89425a5 
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff @thephez
Update spec/abci++/abci++_methods_002_draft.md
9308dd1 
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff shotonoff requested a review from thephez August 15, 2022 14:19
shotonoff
shotonoff commented Aug 15, 2022
View reviewed changes
Copy link
Collaborator Author

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephez thank you for your suggestions, all accepted

thephez
thephez reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also an indenting issue preventing those 2 tables from rendering.

spec/abci++/abci++_methods_002_draft.md Outdated Show resolved Hide resolved
spec/abci++/abci++_methods_002_draft.md Outdated Show resolved Hide resolved
shotonoff and others added 2 commits August 19, 2022 14:55
@shotonoff @thephez
Update spec/abci++/abci++_methods_002_draft.md
aa5e859 
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff @thephez
Update spec/abci++/abci++_methods_002_draft.md
66ed595 
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff shotonoff requested a review from thephez August 19, 2022 12:55
shotonoff
shotonoff commented Aug 19, 2022
View reviewed changes
Copy link
Collaborator Author

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephez suggested accepted

@shotonoff shotonoff merged commit 6dd4bcc into v0.9-dev Sep 1, 2022
@shotonoff shotonoff deleted the TD-85-update-abci++-spec branch September 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thephez thephez thephez approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@lklimek lklimek Awaiting requested review from lklimek lklimek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shotonoff @thephez