fix(kvstore): Same-block execution support for persistent KV store #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotonoff
approved these changes
Sep 5, 2022
| @@ -36,11 +34,19 @@ type State struct { | |||
| db dbm.DB | |||
| Height int64 `json:"height"` | |||
| AppHash tmbytes.HexBytes `json:"app_hash"` | |||
|
|
|||
| // validator set update | |||
| valSetUpdate types.ValidatorSetUpdate | |||
There was a problem hiding this comment.
I deprecated storing validator set update from db in my refactoring
lklimek
added a commit
that referenced
this pull request
Sep 9, 2022
* refactor: decouple dash parameters from a MakeBlock function to a Block.SetDashParams method * feat: add node's pro-rtx-hash into a context * feat: add proTxHash into context for consensus/reactor_test.go * feat: some modifications for PoC same-block execution * feat: change an updated struct from round state on uncommitted-state * feat: support next-validators as for next-block execution mode * feat: support next-validators for same-block execution mode * feat: some modifications for next-core-lock * chore: same block execution state/state_test.go (WIP) * test(state): fix TestManyValidatorChangesSaveLoad() * fix(state): panic on empty consensus params load * chore(state): remove state.NextValidators * chore(proto/abci): same block execution protobuf changes * refactor(types): centralize generation of ResultsHash * refactor(state): consolidate redundant code in block execution * chore(state) execution fix for new data structures * test(state): adapt TestProposerPriorityProposerAlternates for same block exec * test(state): same block exec TestFourAddFourMinusOneGenesisValidators * test(state): same block exec TestStoreLoadValidatorsIncrementsProposerPriority * test(state): same block exec for TestManyValidatorChangesSaveLoad * fix(state): same block exec TestConsensusParamsChangesSaveLoad * test(state): fix TestProcessProposal * chore(state): correct handling of ApplyBlock etc * test(mempool): builds but fails * refactor(state): UncommittedState now holds final values instead of updates This was needed for clean implementation of NextValidatorsHash * refactor(state): rename UncommittedChanges to Changeset * chore: same block exec - block * chore(state): state ID - start of work * chore: SBE - block fields (WIP) * chore: SBE chainlocks and proposed app version (WIP) * test(state): SBE green (execution|state|validation)_test * chore(abci): improve validation of prepare/process proposal responses * chore(state): apphash defaults to array containing zeros * test(state): TestStoreLoadValidators fixed for SBE * chore(state): AppHash defaults to slice of 0s instead of nil * chore(state): fix invalid state.LastStateID * test(state): SBE TestPruneStates * test(state): fix rollback_test * fix(abci): correct handling of AppHash in Application * test(store): update for SBE * chore(types): rename stateID.LastAppHash to AppHash * refactor(statesync): state provider returns AppHash as HexBytes * test(statesync): fix for SBE * test(consensus): show test logs on console * test(consensus): fix byzantine test * test(blocksync): update for SBE * fix(state): events fired twice * fix(consensus): proposal contains invalid chainlock height * test(consensus): correct chainlock in initial block in SBE * Update abci/example/kvstore/kvstore.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * Update abci/example/kvstore/kvstore.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * fix(state): double commits during replay * test(consensus): fix replay handshake* tests (WIP) * fix: evidence package * fix: validator_conn_executor_test.go * refactor: executing kvstore * feat!(kvstore): same-block-execution KV store (#447) * feat!(kvstore): same-block-execution KV store * fix(kvstore): dstIter not closed correctly * fix(kvstore): AppHash at genesis should be zero * fix(kvstore): SBE support for persistent KV store (#452) * test(proxy): fix test of Info() * fix: some fixes and refactoring for stabilizing same-block execution (#451) * fix: some fixes and refactoring for stabilizing same-block execution * refactor: merge kvstore.App with kvstore.Application and remove kvstore_v2.go * fix: kvstore_test.go * fix: TestValUpdates * fix: TestValUpdates * fix: TestKVStore * fix: rpc/client tests * fix: make stable some tests affected by kvstore refactoring * fix: update uncommitted state if a validator out of quorum set and a node has proposal block for the height * Update internal/consensus/replay_test.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * refactor: changes according to PR feedback * fix: blocking wal_test.go because of default context * fix: code style issues * fix: abci-cli test * fix: typo in struct name CurentRoundState => CurrentRoundState * fix: a few data race issues * fix: TestHandshakeReplayNone * fix: ValidatorUpdate.MarshalJSON * fix: ValidatorUpdate.UnmarshalJSON * chore(e2e): prototype e2e test app for same-block execution * fix(consensus): state is nil on genesis * fix(state): invalid stateID height on genesis * chore: improve logging * Update abci/tests/server/client.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * Update abci/tests/server/client.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * Update internal/proxy/client_test.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * refactor: changes according to PR feedback Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * fix: stabilize codebase after merge / resolve conflicts Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only