refactor: blocksync.bpRequester should stop procedure if block was received #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotonoff
force-pushed
the
refactor-blocksync-block-peer-requester
branch
from
b96a067
to
841ec00
Compare
lklimek
reviewed
Jan 2, 2023
lklimek
previously approved these changes
Jan 2, 2023
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
shotonoff
commented
Jan 3, 2023
lklimek
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Even if during block sync operation a block was received then a routine still waits until a context will cancel
What was done?
bpRequester.requestRoutineif a block is receivedbpRequester.requestRoutineHow Has This Been Tested?
Unit/E2E tests
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only