fix: update quorum params #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should move this to BLS library?
wt., 2 maj 2023, 19:27 użytkownik Dmitrii Golubev ***@***.***>
napisał:
… @shotonoff <https://github.com/shotonoff> requested your review on: #626
<#626> fix: update quorum
params as a code owner.
—
Reply to this email directly, view it on GitHub
<#626 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGNWWT32VMDTGEXCH4YSLTXEE7YVANCNFSM6AAAAAAXTLCOPQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@lklimek BLS library is low level thing which shouldn't know about LLMQ and even Dash )) |
|
@lklimek we add a separate task to the backlog where this settings must be set in config. |
shumkov
approved these changes
May 2, 2023
shotonoff
added a commit
that referenced
this pull request
May 4, 2023
* build(deps): Bump github/super-linter from 4 to 5 (#624) Bumps [github/super-linter](https://github.com/github/super-linter) from 4 to 5. - [Release notes](https://github.com/github/super-linter/releases) - [Changelog](https://github.com/github/super-linter/blob/main/docs/release-process.md) - [Commits](github/super-linter@v4...v5) --- updated-dependencies: - dependency-name: github/super-linter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update quorum params (#626) * refactor: update quorum params * refactor: update quorum params * fix: lint issue * fix: move back btcjson.LLMQType_50_60 * chore(release): update changelog and version to 0.11.1 (#627) * chore: catch up the changes from master into v0.11 dev (#629) * chore(release): update changelog and version to 0.11.0 * fix: invalid threshold for `LLMQType_25_67` (#628) --------- Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some quorum types were missed in
types.QuorumParamsWhat was done?
Synced missed quorum parameters
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only