feat: add ability to write logs in a file #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(release): update changelog and bump version to 0.11.0
* chore: catch up the changes from master into v0.11 dev (#629) * chore(release): update changelog and version to 0.11.0 * fix: invalid threshold for `LLMQType_25_67` (#628) --------- Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> * chore(release): update changelog and version to 0.11.2 --------- Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
shumkov
reviewed
May 4, 2023
lklimek
previously approved these changes
May 5, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # CHANGELOG.md
lklimek
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
By default the logs are written into stderr only. But, we encountered with the case when elastic doesn't have a bunch of the logs, so additionally we need to write the logs into a file along with writing its into stderr output.
What was done?
Added ability to write the logs into the file along with stderr
How Has This Been Tested?
N/A
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only