Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blocksync): migrate peer-manager on generic store #666

Merged
merged 26 commits into from
Aug 21, 2023

Conversation

shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Jul 26, 2023

Issue being fixed or feature implemented

To reduce code duplication, the blocksync peer-manager needs to be migrated on store.Store[types.NodeID, PeerData] component

What was done?

  • blocksync peer-manager wraps store.Store[types.NodeID, PeerData]

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shotonoff shotonoff force-pushed the refactor/blocksync-peer-manager branch from fd6d5d3 to da0647c Compare July 26, 2023 15:22
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Aug 6, 2023
@github-actions github-actions bot closed this Aug 10, 2023
@shotonoff shotonoff reopened this Aug 18, 2023
@github-actions github-actions bot removed the Stale label Aug 19, 2023
@shotonoff shotonoff requested a review from lklimek August 21, 2023 09:00
Copy link
Collaborator Author

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered to the questions

lklimek
lklimek previously approved these changes Aug 21, 2023
Base automatically changed from refactor/td-162-implement-statesync-peer-manager to v0.13-dev August 21, 2023 10:00
@shotonoff shotonoff dismissed lklimek’s stale review August 21, 2023 10:00

The base branch was changed.

@shotonoff shotonoff merged commit d90e058 into v0.13-dev Aug 21, 2023
15 checks passed
@shotonoff shotonoff deleted the refactor/blocksync-peer-manager branch August 21, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants