Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log-file-path setting does not work #691

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: log-file-path setting does not work #691

merged 3 commits into from
Oct 3, 2023

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Oct 2, 2023

Issue being fixed or feature implemented

log-file-path setting does not work

What was done?

  1. Fixed the bug by adding relevant logic to log.OverrideWithNewLogger()
  2. Refactored a bit - moved code from main.rs to log/ and simplifying it
  3. Fixed logger close logic (defer is not triggered when using os.Exit, so we call it explicitly).

How Has This Been Tested?

locally, with make build;./build/tenderdash start

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek requested a review from shumkov October 3, 2023 08:19
shumkov
shumkov approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 89045bb into v0.14-dev Oct 3, 2023
16 checks passed
@shumkov shumkov deleted the fix-log-dest branch October 3, 2023 13:24
lklimek added a commit that referenced this pull request Oct 9, 2023
@lklimek
fix: log-file-path setting does not work (#691)
5bf07cf 
* fix: log-file-path setting does not work

* chore: remove one-liner func

* refactor: simplify a bit
@lklimek lklimek mentioned this pull request Oct 9, 2023
Merged
5 tasks
lklimek added a commit that referenced this pull request Oct 9, 2023
@lklimek
fix: log-file-path setting does not work (#691)
57fa229 
* fix: log-file-path setting does not work

* chore: remove one-liner func

* refactor: simplify a bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@shotonoff shotonoff Awaiting requested review from shotonoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov