Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix linter issues #730

Merged
merged 6 commits into from
Jan 30, 2024
Merged

chore: fix linter issues #730

merged 6 commits into from
Jan 30, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jan 30, 2024 •
edited
Loading

Issue being fixed or feature implemented

golangci-lint fails due to:

  • missing depguard config
  • unused fields, etc.

What was done?

  1. Disabled (not used by us) depguard in golangci-lint config
  2. Tuned golangci configuration
  3. Trigger GHA when golangci-lint config changes
  4. Fixed linter issues (mainly renamed unused fields)
  5. Replaced deprecated functions from math/rand package with "golang.org/x/exp/rand"

How Has This Been Tested?

Locally calling golangci-lint run + github actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek enabled auto-merge (squash) January 30, 2024 09:03
@lklimek lklimek changed the title build: fix depguard linter configuration build: disable depguard in linter configuration Jan 30, 2024
@lklimek lklimek changed the title build: disable depguard in linter configuration chore: fix linter issues Jan 30, 2024
shumkov
shumkov approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 86a79ac into v0.14-dev Jan 30, 2024
30 of 34 checks passed
@shumkov shumkov deleted the build/depguard branch January 30, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@shotonoff shotonoff Awaiting requested review from shotonoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov