-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(consensus): valid/locked block incorrectly marked as not timely #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
force-pushed
the
fix/valid-block
branch
from
March 12, 2024 15:51
280a610
to
1987c49
Compare
lklimek
changed the title
fix(consensus): proposal creation regenerates blocks too often
fix(consensus): valid/locked block incorrectly marked as not timely
Mar 12, 2024
shumkov
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Due to invalid handling of ValidBlock/LockedBlock receive time, Tenderdash interprets some blocks as not timely.
It causes unnecessary PrepareProposal calls when previous block should be reused but is not due to "not timely" issue, as well as rejecting blocks as "not timely" during voting.
This can also trigger issues if ABCI App response prepare proposal changes between rounds.
What was done?
How Has This Been Tested?
Github Actions + tested during Dash Platform load tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only