Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement optimizer rule to eliminate double distinct #1008

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement optimizer rule to eliminate double distinct #1008

wants to merge 1 commit into from

Conversation

ChrisJar
Copy link
Collaborator

Closes #925

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #1008 (b464529) into main (7da66be) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
+ Coverage   80.47%   80.59%   +0.11%     
==========================================
  Files          75       75              
  Lines        4231     4231              
  Branches      765      765              
==========================================
+ Hits         3405     3410       +5     
+ Misses        662      653       -9     
- Partials      164      168       +4
Impacted Files Coverage Δ
dask_sql/_version.py 35.31% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg Awaiting requested review from ayushdg ayushdg will be requested when the pull request is marked ready for review ayushdg is a code owner

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca will be requested when the pull request is marked ready for review charlesbluca is a code owner

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar will be requested when the pull request is marked ready for review galipremsagar is a code owner

@jdye64 jdye64 Awaiting requested review from jdye64 jdye64 will be requested when the pull request is marked ready for review jdye64 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Create an optimizer rule to remove redundant Distinct calls
2 participants
@ChrisJar @codecov-commenter