Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the hive tests #221

Merged
merged 7 commits into from
Aug 21, 2021
Merged

Re-enable the hive tests #221

merged 7 commits into from
Aug 21, 2021

Conversation

nils-braun
Copy link
Collaborator

@nils-braun nils-braun commented Aug 20, 2021

Due to me being stupid, there was no hive test in the moment.
Additionally, the move to a new git space disabled all coverage tests and display of the results.
We are fixing both here and bring the coverage to 100% back again.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #221 (be484d8) into main (0c3a6a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #221    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           64        64            
  Lines         2470      2589   +119     
  Branches       340       362    +22     
==========================================
+ Hits          2470      2589   +119     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/filter.py 100.00% <ø> (ø)
dask_sql/context.py 100.00% <100.00%> (ø)
dask_sql/input_utils/hive.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/custom/create_experiment.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/custom/create_model.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/custom/export_model.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/logical/__init__.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/logical/join.py 100.00% <100.00%> (ø)
dask_sql/physical/rel/logical/window.py 100.00% <100.00%> (ø)
dask_sql/physical/rex/core/__init__.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b60e4a...be484d8. Read the comment docs.

@nils-braun
Copy link
Collaborator Author

The dark-cluster test fails until the dask docker image is also updated, so we can proceed here anyways.

@nils-braun nils-braun merged commit 4dab949 into main Aug 21, 2021
@nils-braun nils-braun deleted the bugfix/reenable-hive-tests branch August 21, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants