Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Left/Right/Inner Join (inequality) #222

Closed
wants to merge 4 commits into from
Closed

Improve Left/Right/Inner Join (inequality) #222

wants to merge 4 commits into from

Conversation

flcong
Copy link

@flcong flcong commented Aug 21, 2021 •
edited
Loading

  • Improve Left/Right/Inner Join for inequality conditions (Left Join becomes Inner Join for inequality conditions #190)
  • For left (right) join, set as pd.NA for values from the right (left) table and drop duplicates if the inequality condition is not satisfied.
  • Add additional more complicated tests for left/right/inner join (both fixture and tests)
  • Full Join is not implemented yet.

@flcong
Improve Left/Right/Inner Join (inequality)
f5e2abb 
> Improve Left/Right/Inner Join for inequality conditions.
> For left (right) join, set as pd.NA for values from the right (left) table and drop duplicates if the inequality condition is not satisfied.
> Add additional more complicated tests for left/right/inner join (both fixture and tests)
> Full Join is not implemented yet.
@flcong flcong changed the title Improve Left/Right/Inner Join (inequality) #190 Improve Left/Right/Inner Join (inequality) Aug 21, 2021
@flcong flcong marked this pull request as ready for review August 21, 2021 22:02
@flcong flcong closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flcong