Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpuCI support #240

Merged
merged 17 commits into from
Oct 5, 2021
Merged

Conversation

charlesbluca
Copy link
Collaborator

@charlesbluca charlesbluca commented Sep 16, 2021

This PR adds:

@codecov-commenter
Copy link

Codecov Report

Merging #240 (86f19f0) into main (4d5f7dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         2590      2588    -2     
  Branches       361       361           
=========================================
- Hits          2590      2588    -2     
Impacted Files Coverage Δ
dask_sql/utils.py 100.00% <0.00%> (ø)
dask_sql/physical/rel/custom/predict.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5f7dd...86f19f0. Read the comment docs.

@charlesbluca charlesbluca changed the title [WIP] Add gpuCI support Add gpuCI support Oct 1, 2021
@charlesbluca charlesbluca marked this pull request as ready for review October 1, 2021 17:58
Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks for adding gpuCI to the project.
Once updates are made upstream such that gpuCI starts running tests against PR's here we might explore codecov and remote the #pragma no cover in places they were added since we didn't test earlier. Eg: #224

Comment on lines +111 to +112
assert isinstance(result, dd.DataFrame if not gpu else dask_cudf.DataFrame)
dd.assert_eq(result, data_frame)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to assert_correct_input it might be valuable wrapping something that does this as a more common utility for pytests in a followup PR.

@charlesbluca charlesbluca merged commit 3d4296b into dask-contrib:main Oct 5, 2021
@charlesbluca charlesbluca deleted the add-gpu-tests branch January 19, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants