-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gpuCI support #240
Add gpuCI support #240
Conversation
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 2590 2588 -2
Branches 361 361
=========================================
- Hits 2590 2588 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Thanks for adding gpuCI to the project.
Once updates are made upstream such that gpuCI starts running tests against PR's here we might explore codecov and remote the #pragma no cover
in places they were added since we didn't test earlier. Eg: #224
assert isinstance(result, dd.DataFrame if not gpu else dask_cudf.DataFrame) | ||
dd.assert_eq(result, data_frame) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to assert_correct_input
it might be valuable wrapping something that does this as a more common utility for pytests in a followup PR.
This PR adds:
gpu
, which when added to tests causes them to be skipped by default unless--rungpu
is provided