Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cython dependency. #13

Closed
rzu512 opened this issue Feb 3, 2018 · 4 comments
Closed

cython dependency. #13

rzu512 opened this issue Feb 3, 2018 · 4 comments

Comments

@rzu512
Copy link

rzu512 commented Feb 3, 2018

When I try to install crick by pip3, pip3 doesn't install Cython automatically.

$ pip3 install crick --user

Collecting crick
  Using cached crick-0.0.3.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-y1mcfhjt/crick/setup.py", line 7, in <module>
        from Cython.Build import cythonize
    ModuleNotFoundError: No module named 'Cython'
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-y1mcfhjt/crick/
@rzu512 rzu512 changed the title cython dependency in pip installation installation problems Feb 4, 2018
@rzu512 rzu512 changed the title installation problems cython dependency. Feb 4, 2018
@jcrist
Copy link
Member

jcrist commented Feb 21, 2018

This is a bit tricky to do cleanly due to how setup.py scripts are run. I'll resolve this for sure before the next release, but the resolution might be just to remove cython completely (see #17).

Note that binary releases are available for all OS's with conda, and for osx (currently) on pypi. A manylinux and windows build setup could be done for pypi as well, but it's not high priority for me.

@shughes-uk
Copy link

@jcrist poke

@MuellerSeb
Copy link

This is solved with the pyproject.toml that defines build time dependencies.

Added here: #39

@milesgranger
Copy link
Collaborator

Thanks, @MuellerSeb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants