Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cython? #17

Open
3 tasks
jcrist opened this issue Feb 21, 2018 · 1 comment
Open
3 tasks

Remove Cython? #17

jcrist opened this issue Feb 21, 2018 · 1 comment

Comments

@jcrist
Copy link
Member

jcrist commented Feb 21, 2018

Currently Cython is used just as a thin wrapper around C code. This is a bit tricky, since our C code also touches the python/numpy c-api, and so reference counting must remain consistent through the two layers. In my experience developing this I've started to wonder if removing cython in favor of a straight C-extension might make more sense. This would also generate a much smaller binary, as Cython generated modules have a fair bit of bloat.

Modules to conver

  • Statistics (I'll start with this one, as it'll be the easiest)
  • TDigest
  • Space Saving
@rzu512
Copy link

rzu512 commented Feb 22, 2018

If the cython part and c part are separated, people can use the c part in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants