Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dask version to 2021.11.0 #194

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Update Dask version to 2021.11.0 #194

merged 2 commits into from
Nov 6, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 6, 2021

A new Dask version has been detected.

Updated Dockerfiles to use 2021.11.0.

@github-actions github-actions bot added the automerge PRs with this label will be auto merged on passing CI label Nov 6, 2021
@github-actions github-actions bot force-pushed the upgrade-dask-version branch from 63fe595 to f8961ee Compare November 6, 2021 04:06
@jrbourbeau jrbourbeau force-pushed the upgrade-dask-version branch from f8961ee to 63fe595 Compare November 6, 2021 04:45
@jrbourbeau jrbourbeau merged commit 6a2eb19 into main Nov 6, 2021
@jakirkham
Copy link
Member

Thanks James! 😄

Sorry to see the autoupdate script isn't updating the versions completely. Had tried to make some changes in PR ( #192 ), which seemed ok from local testing, but that doesn't seem to have been sufficient.

@jacobtomlinson do you have any thoughts on how we can get the autoupdate script to update all of these versions? Is there a better way to test it than playing with grep locally 😂

@jacobtomlinson
Copy link
Member

@jakirkham you could build and run the action locally. It's a small Go app.

However it seems the README isn't being updated because it isn't included.

include: '\.github\/workflows\/build\.yml|build\/docker-compose\.yml'

@jakirkham
Copy link
Member

Thanks for pointing that out Jacob 🙂

It’s not just the README though. It missed one of the GH Actions files, which does appear to be listed there

@jakirkham
Copy link
Member

Submitted PR ( #195 ) to add README.md to that list

That said, still confused as to why .github/workflows/build.yml is getting ignored during the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PRs with this label will be auto merged on passing CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants