Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dask version to 2024.1.1 #307

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Update Dask version to 2024.1.1 #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff3d01
Update Dask version to 2024.1.1
github-actions[bot] Jan 27, 2024
7d22b9a
Pin mambaforge image
jrbourbeau Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest

env:
release: "2024.1.0"
release: "2024.1.1"
defaultpython: "3.10"

strategy:
Expand Down
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
| `ghcr.io/dask/dask-notebook` | Jupyter Notebook image to use as helper entrypoint | [![][daskdev-dask-notebook-py310-release] ![][daskdev-dask-notebook-release] ![][daskdev-dask-notebook-latest] <br /> ![][daskdev-dask-notebook-py39-release] <br /> ![][daskdev-dask-notebook-py311-release]](https://github.com/dask/dask-docker/pkgs/container/dask-notebook) |

[daskdev-dask-latest]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-latest-blue
[daskdev-dask-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.0-blue
[daskdev-dask-py39-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.0--py3.9-blue
[daskdev-dask-py310-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.0--py3.10-blue
[daskdev-dask-py311-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.0--py3.11-blue
[daskdev-dask-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.1-blue
[daskdev-dask-py39-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.1--py3.9-blue
[daskdev-dask-py310-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.1--py3.10-blue
[daskdev-dask-py311-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask-2024.1.1--py3.11-blue
[daskdev-dask-notebook-latest]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-latest-blue
[daskdev-dask-notebook-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.0-blue
[daskdev-dask-notebook-py39-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.0--py3.9-blue
[daskdev-dask-notebook-py310-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.0--py3.10-blue
[daskdev-dask-notebook-py311-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.0--py3.11-blue
[daskdev-dask-notebook-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.1-blue
[daskdev-dask-notebook-py39-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.1--py3.9-blue
[daskdev-dask-notebook-py310-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.1--py3.10-blue
[daskdev-dask-notebook-py311-release]: https://img.shields.io/badge/ghcr.io%2Fdask%2Fdask--notebook-2024.1.1--py3.11-blue


## Example
Expand Down
2 changes: 1 addition & 1 deletion base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_CONTAINER=condaforge/mambaforge:latest
ARG BASE_CONTAINER=condaforge/mambaforge:23.3.1-1
FROM $BASE_CONTAINER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Python 3.9 docker builds were failing (see this CI build) with this conda solve issue

#7 [2/4] RUN mamba install -y     "mamba>=0.27.0"     python=3.9     nomkl     cmake     dask=2024.1.1     cachey     streamz     && mamba clean -tipy     && find /opt/conda/ -type f,l -name '*.a' -delete     && find /opt/conda/ -type f,l -name '*.pyc' -delete     && find /opt/conda/ -type f,l -name '*.js.map' -delete     && find /opt/conda/lib/python*/site-packages/bokeh/server/static -type f,l -name '*.js' -not -name '*.min.js' -delete     && rm -rf /opt/conda/pkgs
#7 16.82 
#7 16.82 Looking for: ["mamba[version='>=0.27.0']", 'python=3.9', 'nomkl', 'cmake', 'dask=2024.1.1', 'cachey', 'streamz']
#7 16.82 
#7 16.82 Could not solve for environment specs
#7 16.82 The following packages are incompatible
#7 16.82 ├─ python 3.9**  is requested and can be installed;
#7 16.82 └─ truststore is not installable because it requires
#7 16.82    └─ python >=3.10  but there are no viable options
#7 16.82       ├─ python [3.10.0|3.10.1|...|3.12.1] conflicts with any installable versions previously reported;
#7 16.82       └─ python 3.12.0rc3 would require
#7 16.82          └─ _python_rc, which does not exist (perhaps a missing channel).
#7 ERROR: process "/bin/bash -c mamba install -y     \"mamba>=0.27.0\"     python=${PYTHON_VERSION}     nomkl     cmake     dask=${DASK_VERSION}     cachey     streamz     && mamba clean -tipy     && find /opt/conda/ -type f,l -name '*.a' -delete     && find /opt/conda/ -type f,l -name '*.pyc' -delete     && find /opt/conda/ -type f,l -name '*.js.map' -delete     && find /opt/conda/lib/python*/site-packages/bokeh/server/static -type f,l -name '*.js' -not -name '*.min.js' -delete     && rm -rf /opt/conda/pkgs" did not complete successfully: exit code: 1
------
 > [2/4] RUN mamba install -y     "mamba>=0.27.0"     python=3.9     nomkl     cmake     dask=2024.1.1     cachey     streamz     && mamba clean -tipy     && find /opt/conda/ -type f,l -name '*.a' -delete     && find /opt/conda/ -type f,l -name '*.pyc' -delete     && find /opt/conda/ -type f,l -name '*.js.map' -delete     && find /opt/conda/lib/python*/site-packages/bokeh/server/static -type f,l -name '*.js' -not -name '*.min.js' -delete     && rm -rf /opt/conda/pkgs:
16.82 Looking for: ["mamba[version='>=0.27.0']", 'python=3.9', 'nomkl', 'cmake', 'dask=2024.1.1', 'cachey', 'streamz']
16.82 
16.82 Could not solve for environment specs
16.82 The following packages are incompatible
16.82 ├─ python 3.9**  is requested and can be installed;
16.82 └─ truststore is not installable because it requires
16.82    └─ python >=3.10  but there are no viable options
16.82       ├─ python [3.10.0|3.10.1|...|3.12.1] conflicts with any installable versions previously reported;
16.82       └─ python 3.12.0rc3 would require
16.82          └─ _python_rc, which does not exist (perhaps a missing channel).

I was able to work around this by pinning to the second-to-latest condaforge/mambaforge, which seems like a reasonable fix. cc @jacobtomlinson for visibility


ARG python="3.10"
Expand Down
6 changes: 3 additions & 3 deletions build/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
context: ../base
dockerfile: Dockerfile
args:
release: "2024.1.0"
release: "2024.1.1"
image: ghcr.io/dask/dask:latest
hostname: dask-scheduler
ports:
Expand All @@ -28,7 +28,7 @@ services:
dockerfile: Dockerfile
args:
python: "3.10"
release: "2024.1.0"
release: "2024.1.1"
image: ghcr.io/dask/dask:latest
hostname: dask-worker
command: [ "dask-worker", "tcp://scheduler:8786" ]
Expand All @@ -40,7 +40,7 @@ services:
args:
base: daskdev
python: "3.10"
release: "2024.1.0"
release: "2024.1.1"
depends_on:
- docker-stacks-foundation
image: ghcr.io/dask/dask-notebook:latest
Expand Down
Loading