Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is a request for comment, it is not a final implementation. I am happy to push it forwards to a completed state if it seems like it will be useful to the overall project structure / aims. Though given how substantial this change is to the overall build process can understand if the changes are too large for the stated aims of this PR.
Warning
It should be noted that bakefiles are still somewhat experimental https://docs.docker.com/build/bake/
First thanks all for the amazing project, really cool to try out this project!
What
This PR aims to address #290 #330 and #128 by migrating the build process from github actions into a docker bakefile for more centralized control over which docker files are built and to allow for multi-arch builds.
Why
In order to be able to build multiarch docker files so that ARM platforms can be tested with. Especially with ARM containers normally being cheaper to run on certain CaaS Platforms for similar amounts of compute. (Also I thought it would be funny to run dask on a raspberry Pi cluster🙊
How
This PR implements a new bakefile which aims to simplify the overall build flow in CI offloading much of the responsibility to docker itself.
It should be noted that:
How to test
See passing CI Jobs here: https://github.com/ryanolee/dask-docker/actions
And relevant docker images here: https://github.com/ryanolee?tab=packages&repo_name=dask-docker
Try:
OR
Run
make build-docker
and import the images from your build context and reference them in a similar way.Has been tested on 4 Node Raspberry Pi cluster using Docker swarm and works as expected for everything I have tried it with so for.
x86 Builds have been tested on WSL2, Ubuntu 24.04 and have worked as expected also.