This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
Fix handling of Job ID #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have tested this on a containerized GE install that I have access to and our LSF cluster. Don't have access to SLURM to test against. So would appreciate help from SLURM users to test this. |
This was referenced Feb 26, 2018
|
Cool. I'm glad to see this. |
|
This looks good to me, however I wont have a chance to test this out till next week sometime |
jakirkham
force-pushed
the
fix_job_id_hdling
branch
4 times, most recently
from
b77a575 to
8b4ab27
Compare
In preparation for separating out the Job and Task IDs, wrap the worker out/err template path line and the out/err path lines in the job template.
jakirkham
force-pushed
the
fix_job_id_hdling
branch
from
8b4ab27 to
d146557
Compare
jakirkham
force-pushed
the
fix_job_id_hdling
branch
from
d146557 to
5595e9f
Compare
|
FWIW happy to do a fresh release of |
|
This appears to be generating the right bits and pieces from the testing that I have done (drmaa is crashing on my system for other reasons) I think this change looks good to me. |
|
Thanks @jcftang. |
|
Released in 0.1.1 on PyPI and conda-forge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Closes #33
Closes #46
Improves the handling of Job ID for different types of DRMAA clusters. Namely creates a session with DRMAA and queries
drmsInfoon that session. This provides information about the specific cluster, which we then check against the supported types (i.e. SLURM, LSF, and SGE). Using this check, we set the correct environment variables for the Job ID and Task ID for each scheduler. In addition, we set what we callJOB_PARAMfor each cluster, which represents the string the scheduler will replace with the Job ID when submitting a job. This should address some issues encountered by SLURM and LSF users.