Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize get_dummies #1053

Merged
merged 2 commits into from
May 2, 2024
Merged

Generalize get_dummies #1053

merged 2 commits into from
May 2, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented May 2, 2024

  • Generalizes get_dummies/GetDummies to work with cudf
  • Fixes a minor bug (missing "sparse" parameter)

@rjzamora rjzamora added the bug Something isn't working label May 2, 2024
@rjzamora rjzamora self-assigned this May 2, 2024
@phofl
Copy link
Collaborator

phofl commented May 2, 2024

I suppose we can't add a test here?

@rjzamora
Copy link
Member Author

rjzamora commented May 2, 2024

I suppose we can't add a test here?

This is a good question. I updated the test to work with both pandas and cudf.

Not sure if we want to add test coverage for the parameters?

@phofl
Copy link
Collaborator

phofl commented May 2, 2024

I think that's fine, it would be covered by the gpu ci, correct?

@phofl phofl merged commit 2f659ee into dask:main May 2, 2024
7 checks passed
@phofl
Copy link
Collaborator

phofl commented May 2, 2024

thx

@rjzamora
Copy link
Member Author

rjzamora commented May 2, 2024

it would be covered by the gpu ci, correct?

I'm working on this :)

@rjzamora rjzamora deleted the fix-get_dummies branch May 2, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants