-
Notifications
You must be signed in to change notification settings - Fork 88
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unpin dask-gateway-server's setuptools for Python 3.12+
The point is to make it compatible with Python 3.12, which is considered more important than having a functional editable install.
- Loading branch information
1 parent
583c212
commit c753046
Showing
2 changed files
with
20 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,28 @@ | ||
[build-system] | ||
requires = [ | ||
# setuptools is pinned to 63 because 64+ has introduced the "editable_wheel" | ||
# command to replace the "develop" command, and that doesn't respect | ||
# package_data config. We rely on that to get our golang built proxy | ||
# accessible currently! | ||
# FIXME: dask-gateway-server's editable install is broken with setuptools | ||
# 64+ that introduced the "editable_wheel" command to replace the | ||
# "develop" command, and that doesn't respect package_data config. We | ||
# rely on that to get our golang built proxy accessible currently! | ||
# | ||
# Message when using "setuptools>=64" during "pip install --editable .": | ||
# At the same time, setuptools 63 and older doesn't support Python | ||
# 3.12, so we end up with a broken editable install in Python 3.12 | ||
# until this is resolved. | ||
# | ||
# Editable install will be performed using a meta path finder. | ||
# Message when using "setuptools>=64" during "pip install --editable .": | ||
# | ||
# Options like `package-data`, `include/exclude-package-data` or | ||
# `packages.find.exclude/include` may have no effect. | ||
# Editable install will be performed using a meta path finder. | ||
# | ||
# The problematic result is that we end up without a golang binary in | ||
# dask_gateway_server/proxy/dask-gateway-proxy. | ||
# Options like `package-data`, `include/exclude-package-data` or | ||
# `packages.find.exclude/include` may have no effect. | ||
# | ||
# This is tracked in https://github.com/dask/dask-gateway/issues/740 and can | ||
# be discussed further there. | ||
# The problematic result is that we end up without a golang binary in | ||
# dask_gateway_server/proxy/dask-gateway-proxy. | ||
# | ||
"setuptools==63.*", | ||
# This is tracked in https://github.com/dask/dask-gateway/issues/740 | ||
# | ||
'setuptools==63.* ; python_version < "3.12"', | ||
'setuptools==69.* ; python_version >= "3.12"', | ||
"wheel", | ||
] | ||
build-backend = "setuptools.build_meta" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters