-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with distributed >= 2022.5.1 and traitlets >= 5.2.0, and raise the lower bound of required versions #573
Conversation
38396a5
to
5cdfc78
Compare
It seems that in distributed 2022.05.1, dask/distributed#6363 was introduced, and that removes a |
b295db8
to
eb49e86
Compare
eb49e86
to
8eee259
Compare
Haven't looked closely here, but linking to dask/distributed#6561. With that PR to distributed, we can perhaps avoid changing the dask / distributed requirements. The current release will still be incompatible |
EDIT: Compromise suggestion in #573 (review). My concern relates to #539. It adds maintenance burden to ensure that things work with old versions, so keeping an old lower bound that we don't test doesn't feel great. What should be done ideally, is to run tests against the oldest versions declared support for, like done in jupyterhub: https://github.com/jupyterhub/jupyterhub/blob/f6eec29aa222276ea8a9d8066eabb53e9f65b1a7/.github/workflows/test.yml#L132-L159. If that is done, it seems more acceptable to me to retain an old lower version bound. But of course, this adds maintenance burden - especially if we add such tests with very old lower bounds that are around for historical reasons. I have worked very hard to reduce the complexity of this project's many separate dependencies, reducing complexity has been critical for the maintenance sustainability. Due to that it feels troublesome to add in If you don't think retaining support for a broad version range is quite important, I suggest we still make dask-gateway require a modern version of these dependencies to reduce our maintenance burden and help users end up with something more likely to work, even if it means they are forced to make some updates. |
@TomAugspurger I'd like to go for a release and get this resolved today if possible, is #573 (comment) reasonable to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks.
Closes #571.
I've observed a flurry of issues that created a very hard to debug situation, but this resolves them all I think. This patch makes us require modern versions of
distributed
,traitlets
,click
, anddask
though. Unless we have tests against the minimum required versions, I think its better that we do this than hope a version could be slightly lower without issues though.The
click
issue as seen on a scheduler pod starting and quickly terminating.